feat: engine order header ordering for regex configurations by SkArchon · Pull Request #2180 · wundergraph/cosmo

SkArchon · 2025-09-01T08:39:25Z

This PR incorporates the engine changes for header ordering before creating a hash

Summary by CodeRabbit

Chores
- Bumped an internal GraphQL tooling dependency to the next release candidate to incorporate upstream fixes.
- Improves stability, compatibility, and minor performance under the hood.
- No changes to user workflows, configuration, APIs, or schemas.
- No user-facing behavior changes expected; seamless upgrade.

Checklist

I have discussed my proposed changes in an issue and have received approval to proceed.
I have followed the coding standards of the project.
Tests or benchmarks have been added or updated.
Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
I have read the Contributors Guide.

coderabbitai · 2025-09-01T08:39:32Z

Walkthrough

Bumped the required version of github.com/wundergraph/graphql-go-tools/v2 from v2.0.0-rc.223 to v2.0.0-rc.224 in two go.mod files. No other code, configuration, or exported declarations were changed.

Changes

Cohort / File(s)	Summary of edits
Dependency version bumps `router/go.mod`, `router-tests/go.mod`	Updated `require` entry for `github.com/wundergraph/graphql-go-tools/v2` from `v2.0.0-rc.223` to `v2.0.0-rc.224`; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-09-01T08:41:38Z

❌ Internal Query Planner CI checks failed

The Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR.
If you are part of the WunderGraph organization, you can see the PR with more details.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 67c417f and d0ebd5c.

⛔ Files ignored due to path filters (1)

router/go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

router/go.mod (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: StarpTech
PR: wundergraph/cosmo#2157
File: router-tests/go.mod:16-16
Timestamp: 2025-08-20T22:13:25.222Z
Learning: github.com/mark3labs/mcp-go v0.38.0 has regressions and should not be used in the wundergraph/cosmo project. v0.36.0 is the stable version that should be used across router-tests and other modules.

📚 Learning: 2025-08-20T22:13:25.222Z

Learnt from: StarpTech
PR: wundergraph/cosmo#2157
File: router-tests/go.mod:16-16
Timestamp: 2025-08-20T22:13:25.222Z
Learning: github.com/mark3labs/mcp-go v0.38.0 has regressions and should not be used in the wundergraph/cosmo project. v0.36.0 is the stable version that should be used across router-tests and other modules.

Applied to files:

router/go.mod

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

GitHub Check: build-router
GitHub Check: Analyze (go)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: build_push_image (nonroot)
GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
GitHub Check: build_push_image
GitHub Check: integration_test (./events)
GitHub Check: image_scan
GitHub Check: image_scan (nonroot)
GitHub Check: integration_test (./telemetry)

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d0ebd5c and fb2f336.

⛔ Files ignored due to path filters (1)

router-tests/go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

router-tests/go.mod (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-20T22:13:25.222Z

Learnt from: StarpTech
PR: wundergraph/cosmo#2157
File: router-tests/go.mod:16-16
Timestamp: 2025-08-20T22:13:25.222Z
Learning: github.com/mark3labs/mcp-go v0.38.0 has regressions and should not be used in the wundergraph/cosmo project. v0.36.0 is the stable version that should be used across router-tests and other modules.

Applied to files:

router-tests/go.mod

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: build-router
GitHub Check: image_scan (nonroot)
GitHub Check: build_push_image (nonroot)
GitHub Check: build_push_image
GitHub Check: integration_test (./telemetry)
GitHub Check: image_scan
GitHub Check: integration_test (./events)
GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
GitHub Check: build_test
GitHub Check: Analyze (go)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: build_test

…-creating-hash-for-deduplication

StarpTech

LGTM

fix: update go.mod

d0ebd5c

SkArchon marked this pull request as ready for review September 1, 2025 08:39

SkArchon requested review from Noroth, StarpTech, devsergiy and jensneuse as code owners September 1, 2025 08:39

github-actions Bot added the router label Sep 1, 2025

coderabbitai Bot reviewed Sep 1, 2025

View reviewed changes

Comment thread router/go.mod

fix: cleanup

fb2f336

coderabbitai Bot reviewed Sep 1, 2025

View reviewed changes

Comment thread router-tests/go.mod

Merge branch 'main' into milinda/eng-7955-engine-order-headers-before…

04e7d18

…-creating-hash-for-deduplication

SkArchon requested a review from endigma as a code owner September 1, 2025 16:37

endigma approved these changes Sep 1, 2025

View reviewed changes

endigma requested a review from alepane21 September 1, 2025 17:48

StarpTech approved these changes Sep 1, 2025

View reviewed changes

SkArchon merged commit 0f15d1e into main Sep 2, 2025
71 of 76 checks passed

SkArchon deleted the milinda/eng-7955-engine-order-headers-before-creating-hash-for-deduplication branch September 2, 2025 09:24

Noroth mentioned this pull request Sep 30, 2025

chore: cleanup git history #2248

Closed

5 tasks

coderabbitai Bot mentioned this pull request Mar 4, 2026

fix(router): fix gRPC nested fields mapping inside inline fragments #2584

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: engine order header ordering for regex configurations#2180

feat: engine order header ordering for regex configurations#2180
SkArchon merged 3 commits intomainfrom
milinda/eng-7955-engine-order-headers-before-creating-hash-for-deduplication

SkArchon commented Sep 1, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 1, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

github-actions Bot commented Sep 1, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

StarpTech left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

SkArchon commented Sep 1, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

coderabbitai Bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

github-actions Bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Internal Query Planner CI checks failed

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StarpTech left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SkArchon commented Sep 1, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented Sep 1, 2025 •

edited

Loading